@Akeel_malik Please recheck your PR. ASAP!!!
I corrected the Issue!
1 Like
Thank you, you did not have to send a new PR for this right? Given that we just have to change the Google sheet details.
Yeah! I just corrected the mistake in the google sheet
1 Like
Hi, I feel like when we use the scale parameter we are losing the quality of the images.
Please check the difference of the Researchers section before using the scale parameter and after using the scale parameter.
Before using scale parameter:- https://sefglobal.org/irc.html
After using scale parameter:- https://pr-1014-sef-site.surge.sh/irc.html
WDYT?
Also @Gajindu_Bandara It would be great if you can fix the missing designations of the speakers’ section of the Onelive page too.
1 Like
I felt it to… Then let’s increase the width and height a bit
Before re-scaling the Images, most of them were in the 150x150 render size. So should I increase the image render sizes? 
Let’s increase it a bit like 200x200
Ok ! I’ll increase the render size
Updated the PR. Is it ok now ??? @jaye @Janeth_Fernando
3 Likes
@akshika47 @EngTeam This is the current status of the JSON replacement project 
https://docs.google.com/document/d/1pBSHbUVRJYvK_QI1VCldnUvDt7vXxLykvUy5H_AHFpk/edit
6 Likes
I love your style of working. Really well organised. Let’s make sure we do a QA round after each issue as well.
@akshika47 @EngTeam I checked the usage of the JSON files in the repository but I found out that only team.json, irc.json and irc_interns_2020.json from the assets/content/json are used on the site. So what about the others. Are we gonna remove them from the repository or should I create google sheets for them?
@akshika47 @EngTeam Do we need google sheets for the featured story section in ScholarX:thinking:
@Gajindu_Bandara If the JSON files are not used in the website. You can remove them. If we want them later we can checkout to a previous commit and get them.
WDYT? @Janeth_Fernando
2 Likes
Yeah i also think that we can remove the JSON files which are not used anymore.
1 Like
@Gimhan_minion @Janeth_Fernando As the other JSON files (assets/content/json) are not used in the pages should I remove them from the repository?
1 Like
First, check the usage of each of the JSON files. If they aren’t used, You can remove them.
I would move them to an Archive first. Don’t fully delete them. We have not run the Google sheet method for a long period of time, we might find other problems. So better to keep these ready if we need to revert. Otherwise, you can delete it, we can revert back to the Git commit to finding the JSON. Whatever easier is fine.
2 Likes
@EngTeam @akshika47 I created the last PR to remove the unused JSON files. When that PR is merged, the JSON replacement project is over!!! 
I’m thankful to everyone for guiding and helping me throughout this 
https://docs.google.com/document/d/1pBSHbUVRJYvK_QI1VCldnUvDt7vXxLykvUy5H_AHFpk/edit?usp=sharing
Next, I’m moving to the Image migration thing. I’ll create a new thread for that 
2 Likes