Hi all, this thread is to discuss about improving the UI of the Mentor Approval scene in the “Mentor-Confirmation” state.
Current Design
Suggested Improvements:
Improve the radio buttons.
Feel free to add your suggestions and comments below. @EngTeam
1 Like
Progress Update:
I came up with two suggestions, please find the wireframes attached below and add your comments and suggestion below. @Gravewalker @anjisvj @jaye
Display each mentor in a card as in “Apply for a Mentor”, and the user can select one of those cards, click on confirm.
Remove the “Confirm” button and add a “Select” button in front of each mentor.
3 Likes
I love the first design. Shall we move forward with that?
I also like the first design. Good job! @kumuditha_udayanga
Great, I’ll start working on it.
2 Likes
I think we can remove the confirm button. WDYT @Gravewalker ?
1 Like
I think the button is ‘fine’ to be there. That mitigates accidental clicks. Good for ‘Error Prevention’ What do you think?
2 Likes
That confirmation popup will be there anyway
Yup let’s keep the confirm model, @kumuditha_udayanga can we add a blue border to the selected card?? Would look nice.
1 Like
confirm modal is going to be there anyway. The popup will come when user clicks on a mentor instead of the confirm button
2 Likes
I like the confirm button there. Like what @akshika47 has said it’ll mitigate accidental clicks.
2 Likes
I’ve sent the pull request, please review
sef-global:development
← kumuditha-udayanga:master
opened 05:29PM - 14 Jul 21 UTC
## Purpose
The purpose of this PR is to fix #177
## Goals
- Improve th… e UI of mentor confirmation scene in `mentor-confirmation` state.
## Approach
- Remove the radio buttons.
- Display the mentors in selective cards.
## Screenshots
![mentor-Confirmation](https://user-images.githubusercontent.com/27630091/125665885-a49ae30c-f247-4c6e-a005-1b78f78a7053.gif)
## Checklist
- [x] This PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.
- [x] I have read and understood the development best practices guidelines ( http://bit.ly/sef-best-practices )
- [x] My code follows the style guidelines of this project
- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
## Related PRs
N/A
## Test environment
- OS: MacOS BigSur
- Browser: Safari 14.0.1
- IDE: IntelliJ IDEA
2 Likes