Code review notes
Description
A code review was held to do a demonstration and to review the code of admin APIs developed for Academix.
Attendees
@jaye
@Gravewalker
@anjisvj
@piumal1999
Notes
- Return the created object as the response in the create APIs
- Refactor all the admin APIs including data retrieval APIs to use the Entity classes itself instead of the DTOs and Projections.
The possibility of this change has to be tested before implementation. Therefore this will be implemented in a separate PR.- This change will effectively remove all the DTOs and Projection classes.
- This will remove lot of validation code from the service layer.
- After this change, we can update an entity’s data and it’s translations using a single API.
Next steps
- Bring the PR to a mergeable state
- Start working on the second note I have mentioned above