Adding Translations for the AcadeMix

Development
5

Code review on Adding Translations for the AcadeMix

Held on:
2020-08-22T12:30:00Z → 2020-08-22T13:30:00Z

Attendees:
@piumal1999 @jaye @YohanAvishke @Gravewalker @piumal1999 @Gimhan_minion

Description:
The code review was about Adding translations for the categories

Notes:

The following suggestions were made on the code review.

  1. Add a label for translations
  2. Change x mark on the translations to trash icon
  3. Use else ifs instead of if blocks
  4. Change variable names to more accurate ones
  5. Generalise the translation input.
  6. Store available language metadata on a configuration file

Next steps:
Made the requested changes for the PR

1 Like