# Adding Translations for the AcadeMix

**URL:** <https://sef.discourse.group/t/adding-translations-for-the-academix/170>\
**Category:** Development\
**Created:** [August 20, 2020, 12:48pm UTC](https://sef.discourse.group/t/adding-translations-for-the-academix/170 "2020-08-20T12:48:38Z")\
**Posts on this page:** 1\
**Showing post:** 5

<div class="post-metadata">

**Author:** ![anjisvj](https://yyz2.discourse-cdn.com/free1/user_avatar/sef.discourse.group/anjisvj/32/9_2.png) [@anjisvj](https://sef.discourse.group/u/anjisvj)\
**Post date:** [August 22, 2020, 2:58pm UTC](https://sef.discourse.group/t/adding-translations-for-the-academix/170/5 "2020-08-22T14:58:17Z")

</div>

**Code review on Adding Translations for the AcadeMix**

**Held on:**  
2020-08-22T12:30:00Z → 2020-08-22T13:30:00Z

**Attendees:**  
@piumal1999 @jaye @YohanAvishke @Gravewalker @piumal1999@Gimhan_minion

**Description:**  
The code review was about [Adding translations for the categories](https://github.com/sef-global/sef-core/pull/101)

**Notes:**

The following suggestions were made on the code review.

1. Add a label for translations
2. Change x mark on the translations to trash icon
3. Use else ifs instead of if blocks
4. Change variable names to more accurate ones
5. Generalise the translation input.
6. Store available language metadata on a configuration file

**Next steps:**  
Made the requested changes for the PR

---

_[View the full topic](https://sef.discourse.group/t/adding-translations-for-the-academix/170)._